Show checkbox for sepa based payment methods to set allow_redisplay #4503
+811
−375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooj-stripe
force-pushed
the
wooj/sepaAllowRedisplay
branch
from
61ebf8d to
553de95
Compare
wooj-stripe
force-pushed
the
wooj/sepaAllowRedisplay
branch
from
dc175c4 to
e7e31ea
Compare
wooj-stripe
force-pushed
the
wooj/sepaAllowRedisplay
branch
from
eeffed4 to
e7c2c53
Compare
| @@ -30,7 +30,7 @@ class PaymentSheetVerticalUITests: PaymentSheetUITestCase { | |||
| settings.mode = .setup | |||
| settings.customerMode = .new | |||
| settings.currency = .eur | |||
| settings.customerKeyType = .legacy // TODO: Change to customerSessions when adding save checkbox for SEPA | |||
There was a problem hiding this comment.
I also see a TODO like this in PaymentSheetStandardLPMUIOneTests.testSEPADebitPaymentMethod_PaymentSheet. Should we update that one too?
There was a problem hiding this comment.
YES! thank you!!
Comment on lines
634
to
637
| format: STPLocalizedString( | ||
| "Save this account for future %@ payments", | ||
| "Prompt next to checkbox to save bank account." | ||
| ), |
There was a problem hiding this comment.
I see this string and comment hardcoded twice in this file, should we move it to String.Localized?
porter-stripe
previously approved these changes
Feb 11, 2025
porter-stripe
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the consent checkbox for sepa based payment methods when saving and customerSession.features.payment_method_save is set to enabled.
Motivation
allow_redisplay value is not being set for sepa based payment methods
Testing
existing tests & will add additional tests.
Changelog